Skip to content

these are already mentioned in preceding paragraph #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 23, 2025
Merged

these are already mentioned in preceding paragraph #900

merged 2 commits into from
Jun 23, 2025

Conversation

@tshepang
Copy link
Member

@tshepang tshepang commented Jun 15, 2025 •
edited by rustbot
Loading

@rustbot
Copy link
Collaborator

rustbot commented Jun 15, 2025

r? @Zalathar

rustbot has assigned @Zalathar.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 15, 2025
apiraino
apiraino requested changes Jun 15, 2025
View reviewed changes
@jieyouxu
Copy link
Member

jieyouxu commented Jun 22, 2025

r? apiraino
@rustbot author

@rustbot rustbot assigned apiraino and unassigned Zalathar Jun 22, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2025
@tshepang tshepang requested a review from apiraino June 22, 2025 05:14
apiraino
apiraino requested changes Jun 22, 2025
View reviewed changes
@apiraino apiraino enabled auto-merge (squash) June 23, 2025 07:05
@apiraino apiraino mentioned this pull request Jun 23, 2025
Closed
tshepang added 2 commits June 23, 2025 08:49
@tshepang @ehuss
these are already mentioned in preceding paragraph
362f38d
@tshepang @ehuss
re-word to make the 2 roles more distinct
a809dde 
Also, "elevation" is removed, since promotion has already been discussed
in a previous section.
@apiraino apiraino merged commit e9136a0 into rust-lang:master Jun 23, 2025
1 check passed
@tshepang tshepang deleted the patch-8 branch June 23, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apiraino apiraino apiraino approved these changes

Assignees

@apiraino apiraino

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tshepang @rustbot @jieyouxu @apiraino @Zalathar